Add tempqueueprefix option. #54

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@traylenator

This adds a new option for the client

tempqueueprefix = /queue by default.

The motivation for this is that it allows you to set

tempqueueprefix = /temp-queue

for use inside the activemq connector.

This allows you to benefit from

http://activemq.apache.org/apollo/documentation/user-manual.html#Temporary_Destinations

by default the value /queue so all is backwards compatible.

After adding this configuration the temporary queues automatically vanish when the client
closes.

@traylenator

This comment has been minimized.

Show comment Hide comment
@@ -336,7 +341,7 @@ def make_target(agent, type, collective)
case type
when :reply
- target[:name] = ["/queue/" + collective, :reply, "#{Config.instance.identity}_#{$$}"].join(".")
+ target[:name] = ["#{@tempqueueprefix}" + collective, :reply, "#{Config.instance.identity}_#{$$}"].join(".")

This comment has been minimized.

Show comment Hide comment
@ripienaar

ripienaar Oct 8, 2012

Contributor

I guess this can just be @tempquueprefix instead of quoting it in a string? small optmization and readability

@ripienaar

ripienaar Oct 8, 2012

Contributor

I guess this can just be @tempquueprefix instead of quoting it in a string? small optmization and readability

+
+### Message Reply Prefix
+
+The prefix for temporary reply queues can be specified:

This comment has been minimized.

Show comment Hide comment
@ripienaar

ripienaar Oct 8, 2012

Contributor

Perhaps elaborate on the 2 possible use cases with a small bit of info on the difference between queue and temp-queue?

@ripienaar

ripienaar Oct 8, 2012

Contributor

Perhaps elaborate on the 2 possible use cases with a small bit of info on the difference between queue and temp-queue?

@puppetcla

This comment has been minimized.

Show comment Hide comment
@puppetcla

puppetcla Mar 21, 2013

CLA Signed by traylenator on 2012-03-17 21:00:00 -0700

CLA Signed by traylenator on 2012-03-17 21:00:00 -0700

@traylenator

This comment has been minimized.

Show comment Hide comment
@traylenator

traylenator Apr 17, 2013

This should probably be closed as we are certainly not using this and relying instead on garbage collection of queues.

This should probably be closed as we are certainly not using this and relying instead on garbage collection of queues.

@ripienaar

This comment has been minimized.

Show comment Hide comment
@ripienaar

ripienaar Apr 17, 2013

Contributor

yeh will close - did you try temp queues and that didnt work? I've been considering going that route as apparently the bug that prevented that from working well in clusters have been fixed.

Contributor

ripienaar commented Apr 17, 2013

yeh will close - did you try temp queues and that didnt work? I've been considering going that route as apparently the bug that prevented that from working well in clusters have been fixed.

@ripienaar ripienaar closed this Apr 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment