/mcollective-puppet-agent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable splay/force when in daemon mode but not using signal #55

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@olivierHa @puppetcla @richardc @melissa
@olivierHa
Contributor

olivierHa commented Jun 11, 2015

With this fix, now we can get a working "--force" or splay params, in the case when we are running puppet in daemon mode, but we don't want to use signal (to be able to give noop or environment variables)
@puppetcla

This comment has been minimized.

Show comment
Hide comment
@puppetcla

puppetcla Jun 11, 2015

Waiting for CLA signature by @olivierHa

@olivierHa - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

puppetcla commented Jun 11, 2015

Waiting for CLA signature by @olivierHa

@olivierHa - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html
@olivierHa

This comment has been minimized.

Show comment
Hide comment
@olivierHa

olivierHa Jun 12, 2015

Contributor

CLA ok
Contributor

olivierHa commented Jun 12, 2015

CLA ok
@puppetcla

This comment has been minimized.

Show comment
Hide comment
@puppetcla

puppetcla Jun 12, 2015

CLA signed by all contributors.

puppetcla commented Jun 12, 2015

CLA signed by all contributors.
@richardc

This comment has been minimized.

Show comment
Hide comment
@richardc

richardc Jun 12, 2015

Contributor

Please update the commit message so that it (a) spells splay correctly, (b) includes the description of why you're changing what you're changing that's currently just in the pull request description.
Contributor

richardc commented Jun 12, 2015

Please update the commit message so that it (a) spells splay correctly, (b) includes the description of why you're changing what you're changing that's currently just in the pull request description.
@olivierHa

This comment has been minimized.

Show comment
Hide comment
@olivierHa

olivierHa Jun 12, 2015

Contributor

Hello,
It should be better.
Regards
Olivier
Contributor

olivierHa commented Jun 12, 2015

Hello,
It should be better.
Regards
Olivier

@olivierHa olivierHa changed the title from enable spray/force when in daemon mode but not using signal to enable splay/force when in daemon mode but not using signal Jun 15, 2015

Show outdated Hide outdated agent/puppet.rb
@olivierHa

This comment has been minimized.

Show comment
Hide comment
@olivierHa

olivierHa Jun 19, 2015

Contributor

This should be more readable.
Contributor

olivierHa commented Jun 19, 2015

This should be more readable.
@richardc

This comment has been minimized.

Show comment
Hide comment
@richardc

richardc Jun 22, 2015

Contributor

It reads better, now please squash into a single commit with an amended commit message.
Contributor

richardc commented Jun 22, 2015

It reads better, now please squash into a single commit with an amended commit message.

melissa and others added some commits Apr 23, 2015

@melissa @olivierHa
(maint) Remove lucid from build targets 
Ubuntu 10.04 (Lucid Lynx) goes EoL 2015-04-30, and as such, we no longer
want to be building packages for this platform.

https://lists.ubuntu.com/archives/ubuntu-announce/2015-March/000193.html
24dd192
@olivierHa
Enable splay/force options when using puppet in daemon mode, but not … 
…using daemon signal

When using puppet in daemon mode, you can't give additional arguments when using daemon signal to trigger a run.
This patch allow mcollective to pass a splay argument when puppet is running in daemon mode and not handled by signal to trigger a run.
86f007d

@richardc richardc referenced this pull request Jul 6, 2015

Closed

(MCOP-526) Pass splay arguments if signal_daemon is false #58

@richardc

This comment has been minimized.

Show comment
Hide comment
@richardc

richardc Jul 6, 2015

Contributor

You seem to have picked up a stray commit now. I'll stage this to a clean branch and put it up.
Contributor

richardc commented Jul 6, 2015

You seem to have picked up a stray commit now. I'll stage this to a clean branch and put it up.
@richardc

This comment has been minimized.

Show comment
Hide comment
@richardc

richardc Jul 6, 2015

Contributor

#59 is a tidied up version. Thanks for the contribution.
Contributor

richardc commented Jul 6, 2015

#59 is a tidied up version. Thanks for the contribution.

@richardc richardc closed this Jul 6, 2015

@olivierHa

This comment has been minimized.

Show comment
Hide comment
@olivierHa

olivierHa Jul 6, 2015

Contributor

Thanks !
Contributor

olivierHa commented Jul 6, 2015

Thanks !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment