/mcollective-puppet-agent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MCOP-581) do not assume a disabled agent is idle #73

Merged
merged 3 commits into from Jan 5, 2017

Conversation

Reviewers

@MikaelSmith MikaelSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ripienaar @puppetcla @MikaelSmith
@ripienaar
Contributor

ripienaar commented Dec 27, 2016

When the agent is disabled it's assumed to be idle, but there could be a
period where if the agent was not idle when it was disabled it will
still be applying for a while.

This removes the short circuit and always checks the actual status
@puppetcla

This comment has been minimized.

Show comment
Hide comment
@puppetcla

puppetcla Dec 27, 2016

CLA signed by all contributors.

puppetcla commented Dec 27, 2016

CLA signed by all contributors.
Show outdated Hide outdated .travis.yml
@ripienaar

This comment has been minimized.

Show comment
Hide comment
@ripienaar

ripienaar Jan 3, 2017

Contributor

A release of 1.12.0 or 1.11.2 with this would be awesome
Contributor

ripienaar commented Jan 3, 2017

A release of 1.12.0 or 1.11.2 with this would be awesome
@MikaelSmith

This comment has been minimized.

Show comment
Hide comment
@MikaelSmith

MikaelSmith Jan 5, 2017

Member

Typo in the 3rd commit message, and can you squash the 1st and 2nd?
Member

MikaelSmith commented Jan 5, 2017

Typo in the 3rd commit message, and can you squash the 1st and 2nd?
@MikaelSmith

This comment has been minimized.

Show comment
Hide comment
@MikaelSmith

MikaelSmith Jan 5, 2017

Member

The change seems reasonable.
Member

MikaelSmith commented Jan 5, 2017

The change seems reasonable.
@ripienaar

This comment has been minimized.

Show comment
Hide comment
@ripienaar

ripienaar Jan 5, 2017

Contributor

@MikaelSmith removed 1.8.7, squashed things
Contributor

ripienaar commented Jan 5, 2017

@MikaelSmith removed 1.8.7, squashed things
@MikaelSmith

This comment has been minimized.

Show comment
Hide comment
@MikaelSmith

MikaelSmith Jan 5, 2017

Member

That ticket number doesn't seem correct... should be MCOP-581.
Member

MikaelSmith commented Jan 5, 2017 •
edited

That ticket number doesn't seem correct... should be MCOP-581.

ripienaar added some commits Dec 27, 2016

@ripienaar
(MCOP-581) do not assume a disabled agent is idle 
When the agent is disabled it's assumed to be idle, but there could be a
period where if the agent was not idle when it was disabled it will
still be applying for a while.

This removes the short circuit and always checks the actual status
62f1f4a
@ripienaar
(maint) Add 2.9.1 ruby to matrix 
Test against what is in AIO
0f10720
@ripienaar
(maint) drop 1.8.7 from test matrix
c50677f
@ripienaar

This comment has been minimized.

Show comment
Hide comment
@ripienaar

ripienaar Jan 5, 2017

Contributor

fixed that @MikaelSmith
Contributor

ripienaar commented Jan 5, 2017

fixed that @MikaelSmith

@MikaelSmith MikaelSmith changed the title from (MCOP-576) do not assume a disabled agent is idle to (MCOP-581) do not assume a disabled agent is idle Jan 5, 2017

@MikaelSmith MikaelSmith merged commit 0896a8d into puppetlabs:master Jan 5, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment