Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
(maint) Allow PE Windows Agents to be installed through the harness #178
Previously there were several issues that prevented us from running the Windows agents as part of the PE Acceptance Suite this address those issues.
Important things to note:
We added new version checking methods for pulling in the Windows msi. This is the opposite of ideal. The correct solution will be to merge our releasing of Windows and *Nix builds, until that can occur, we are forced to make this concession and write custom code around the process.
PE Windows agents (and facter) must be called by their full path + name.bat. This means they are effectively named differently for this platform/configuration and changes to Command and Host needed to be made accordingly.
The master will now sign --all certs after a waiting period. Windows agents seem to take longer in our infrastructure and with various configurations there are no good clear ways to validate each named agent that might check in. We now, therefore, wait an appropriate amount of time, sign all certs and move forward.
The way of calling Ruby to find its version is different depending on the platform and type of install. We will continue to probe for open source versions of Puppet, but other installs have Ruby bundled and do not vary.
added a commit
this pull request
Mar 23, 2012
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
@justinstoller so I was wrong earlier about needing to specify