(maint) Allow PE Windows Agents to be installed through the harness #178

Merged
merged 6 commits into from Mar 23, 2012

Conversation

Projects
None yet
3 participants
@justinstoller
Member

justinstoller commented Mar 23, 2012

Previously there were several issues that prevented us from running the Windows agents as part of the PE Acceptance Suite this address those issues.

Important things to note:

We added new version checking methods for pulling in the Windows msi. This is the opposite of ideal. The correct solution will be to merge our releasing of Windows and *Nix builds, until that can occur, we are forced to make this concession and write custom code around the process.

PE Windows agents (and facter) must be called by their full path + name.bat. This means they are effectively named differently for this platform/configuration and changes to Command and Host needed to be made accordingly.

The master will now sign --all certs after a waiting period. Windows agents seem to take longer in our infrastructure and with various configurations there are no good clear ways to validate each named agent that might check in. We now, therefore, wait an appropriate amount of time, sign all certs and move forward.

The way of calling Ruby to find its version is different depending on the platform and type of install. We will continue to probe for open source versions of Puppet, but other installs have Ruby bundled and do not vary.

djm68 added a commit that referenced this pull request Mar 23, 2012

Merge pull request #178 from justinstoller/maint/master/pe_windows
(maint) Allow PE Windows Agents to be installed through the harness

@djm68 djm68 merged commit c9ee0e7 into puppetlabs:master Mar 23, 2012

@joshcooper

This comment has been minimized.

Show comment Hide comment
@joshcooper

joshcooper Mar 23, 2012

@justinstoller so I was wrong earlier about needing to specify cmd.exe /c fullpathto/puppet.bat. in that cmd.exe will execute whatever you give it, using its PATH to resolve it. So there should be some incantation of env PATH=... cmd.exe /c puppet agent -t should work.

@justinstoller so I was wrong earlier about needing to specify cmd.exe /c fullpathto/puppet.bat. in that cmd.exe will execute whatever you give it, using its PATH to resolve it. So there should be some incantation of env PATH=... cmd.exe /c puppet agent -t should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment