Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Clear Azure source directory on builds #1776

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@Iristyle
Copy link
Member

commented Aug 14, 2019

  • Occasionally files intended to live in containers get written on
    Windows with the wrong line endings. Linux containers need LF line
    endings for executable scripts and config files (for instance), but
    the default checkout on Windows is CRLF, unless explicitly configured
    to be different.

    Unfortunately a subsequent pull of the code will not reset local
    line endings on Windows, even when .gitattributes is set properly.

    This typically results in RDPing into an Azure DevOps builder and
    manually trashing the source code, so that when the code is next
    checked out, the appropriate LF line endings will be set.

    Instead of doing that, have the s (source) subdirectory purged
    on each build.

    https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#job

(maint) Clear Azure source directory on builds
 - Occasionally files intended to live in containers get written on
   Windows with the wrong line endings. Linux containers need LF line
   endings for executable scripts and config files (for instance), but
   the default checkout on Windows is CRLF, unless explicitly configured
   to be different.

   Unfortunately a subsequent pull of the code will not reset local
   line endings on Windows, even when .gitattributes is set properly.

   This typically results in RDPing into an Azure DevOps builder and
   manually trashing the source code, so that when the code is next
   checked out, the appropriate LF line endings will be set.

   Instead of doing that, have the `s` (source) subdirectory purged
   on each build.

   https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#job

@Iristyle Iristyle requested a review from puppetlabs/night-s-watch as a code owner Aug 14, 2019

@puppetcla

This comment has been minimized.

Copy link

commented Aug 14, 2019

CLA signed by all contributors.

@Iristyle

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Azure passed, but the check never came back to GH for some reason... hmmph.

@Iristyle Iristyle merged commit 9b85830 into puppetlabs:master Aug 14, 2019

1 of 2 checks passed

puppetlabs.puppet-agent
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Iristyle Iristyle deleted the Iristyle:azure-workspace-cleaning branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.