From 2e9a1b86856cff627306f257f49e5c546433251f Mon Sep 17 00:00:00 2001 From: Eric Putnam Date: Fri, 13 Jun 2025 10:02:45 -0700 Subject: [PATCH] (maint) Update GH actions to use DOCKERHUB_TOKEN IT just blessed us with an OAT that will allow us to push to puppet/puppet-dev-tools on dockerhub again. This switches our actions over to use the token instead of our password per dockerhubs docs here https://docs.docker.com/security/for-admins/access-tokens/#use-an-organization-access-token --- .github/workflows/build-test-push.yml | 2 +- .github/workflows/publish-4x-image.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-push.yml b/.github/workflows/build-test-push.yml index 3fbf343..da845b8 100644 --- a/.github/workflows/build-test-push.yml +++ b/.github/workflows/build-test-push.yml @@ -46,7 +46,7 @@ jobs: run: | docker inspect --format='{{json .Config.Labels}}' ${{ secrets.DOCKERHUB_PUSH_USERNAME }}/puppet-dev-tools:$(date +"%F")-$(git rev-parse --short HEAD) - name: Login to Docker Hub - run: echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_LOGIN_USERNAME }} --password-stdin + run: echo ${{ secrets.DOCKERHUB_TOKEN }} | docker login -u ${{ secrets.DOCKERHUB_LOGIN_USERNAME }} --password-stdin - name: Push Docker images run: | docker push ${{ secrets.DOCKERHUB_PUSH_USERNAME }}/puppet-dev-tools:$(date +"%F")-$(git rev-parse --short HEAD)-rootless diff --git a/.github/workflows/publish-4x-image.yml b/.github/workflows/publish-4x-image.yml index 4e2b077..2edeb5b 100644 --- a/.github/workflows/publish-4x-image.yml +++ b/.github/workflows/publish-4x-image.yml @@ -17,7 +17,7 @@ jobs: IMAGE_BASE: "${{ secrets.DOCKERHUB_PUSH_USERNAME }}/puppet-dev-tools" steps: - name: Login to Docker Hub - run: echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_LOGIN_USERNAME }} --password-stdin + run: echo ${{ secrets.DOCKERHUB_TOKEN }} | docker login -u ${{ secrets.DOCKERHUB_LOGIN_USERNAME }} --password-stdin - name: Pull image env: IMAGE_TAG: ${{ github.event.inputs.image_tag }}