(maint) Use GitHub actions instead of Travis and Appveyor CI#288
Merged
jpogran merged 3 commits intopuppetlabs:mainfrom Jan 5, 2021
Merged
(maint) Use GitHub actions instead of Travis and Appveyor CI#288jpogran merged 3 commits intopuppetlabs:mainfrom
jpogran merged 3 commits intopuppetlabs:mainfrom
Conversation
Due to Travis CI changing its CI limits it is no longer functioning for this project. This commit: * Migrates both Travis and Appveyor CI to GitHubActions * Uses a small PowerShell script to generate the test matrix due to the limitations of Workflow YAML * Adds a build and artifact test phase, with a limited retention period
Rubocop and line ending checks are just terrible. Instead just ignore them for rubocop rules.
Previously the acceptance tests were intermittently failing on Windows GitHub Actions runners. I really don't like this. But unfortunately the workspace symbol loading is asynchronous so you don't _really_ know what it's available. We could add another Request or extend puppet/getVersion to emit whether the workspace has been loaded yet. In the meantime just sleep a long time and hope it's loaded by then.
Contributor
Author
|
Note that the Travis and AppVeyor will fail as it no longer has a configuration file. This is expected. |
Contributor
Author
Contributor
Author
|
I don't have rights to remove the Travis and Appveyor integrations. |
jpogran
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287
Due to Travis CI changing its CI limits it is no longer functioning for this
project. This commit:
limitations of Workflow YAML