(GH-66) Fix go to definition #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
GH-331-fix-go-to-definition
branch
2 times, most recently
from
496ff48 to
a77cc1b
Compare
jpogran
changed the title
jpogran
force-pushed
the
GH-331-fix-go-to-definition
branch
from
a77cc1b to
fe567bf
Compare
glennsarti
reviewed
Oct 25, 2018
| end | ||
| private_class_method :function_name | ||
|
|
||
| def self.build_uri(path) |
Contributor
There was a problem hiding this comment.
I wonder if this should be a generic helper. Although, nothing else is broken yet...
Contributor
Author
There was a problem hiding this comment.
I see this being useful in other providers that handle opening or doing things to files
| end | ||
| private_class_method :function_name | ||
|
|
||
| def self.build_uri(path) |
Contributor
There was a problem hiding this comment.
Do we need unit tests on this?
Contributor
Author
|
tested working on ubuntu 18.04
|
jpogran
force-pushed
the
GH-331-fix-go-to-definition
branch
2 times, most recently
from
c7b8676 to
ef8286f
Compare
Contributor
Author
|
@glennsarti did rubocop rules change recently? Tests work, but rubocop is now complaining about hash alignment in files i didn't touch |
Contributor
Contributor
|
I'm happy to merge this without red CI. Rubocop is tested last for a reason :-) |
This commit fixes building file paths on platforms that use leading slashes. Before the `file://` uri had too many slashes with a path that starts with a backslash. This fix checks the string to see if it starts with a slash and adds the appropriate amount of slashes.
jpogran
force-pushed
the
GH-331-fix-go-to-definition
branch
from
ef8286f to
61fcfbb
Compare
jpogran
changed the title
michaeltlombardi
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66, reported in puppetlabs/puppet-vscode#331