Skip to content

Conversation

@glennsarti
Copy link
Contributor

Commit d268b27 pinned rubocop due to a large number of errors it
introduced. This commit reverts the previous version pin and fixes all of the
violations.

Fixes #69

Commit d268b27 pinned rubocop due to a large number of errors it
introduced.  This commit reverts the previous version pin and fixes all of the
violations.
@glennsarti glennsarti added this to the 0.16.0 milestone Nov 9, 2018
@glennsarti glennsarti added enhancement New feature or request Language Server labels Nov 9, 2018
Rubocop prefers source files use snake case for names.  This commit renames the
offending files. A later commit will fix any issues caused by the renames.
Previously a few of the source files were renamed to snake case format.  This
commit updates the tests and ruby require statements for the new file names.
@glennsarti glennsarti changed the title {WIP} (GH-69) Fix rubocop violations from version 0.60.0 (GH-69) Fix rubocop violations from version 0.60.0 Nov 9, 2018
@glennsarti glennsarti requested a review from jpogran November 9, 2018 14:51
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR, ci green LGTM

@jpogran jpogran merged commit 1096ebc into puppetlabs:master Nov 10, 2018
@glennsarti glennsarti deleted the fix-rubocop branch November 12, 2018 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rubocop 0.60.0 has raised many violations

2 participants