Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeclimate (GitLab Code Quality compatible) output support #79

Merged
merged 3 commits into from Feb 28, 2023
Merged

codeclimate (GitLab Code Quality compatible) output support #79

merged 3 commits into from Feb 28, 2023

Conversation

alexjfisher
Copy link

@alexjfisher alexjfisher commented Jan 23, 2023 •
edited

An alternative to #78

Once/if this is accepted, I'll open a pdk-templates PR to add support there.

ekohl
ekohl reviewed Jan 23, 2023
View reviewed changes
lib/puppet-lint/report/codeclimate.rb Outdated Show resolved Hide resolved
lib/puppet-lint/report/codeclimate.rb Outdated Show resolved Hide resolved
@alexjfisher alexjfisher force-pushed the code_climate2 branch 4 times, most recently from f272197 to 9dc19bb Compare February 14, 2023 11:44
@alexjfisher alexjfisher mentioned this pull request Feb 14, 2023
Closed
@alexjfisher alexjfisher changed the title WIP: codeclimate output support (take 2) codeclimate (GitLab Code Quality compatible) output support Feb 14, 2023
@alexjfisher alexjfisher marked this pull request as ready for review February 14, 2023 11:48
@alexjfisher alexjfisher requested a review from a team as a code owner February 14, 2023 11:48
ekohl
ekohl reviewed Feb 14, 2023
View reviewed changes
lib/puppet-lint.rb Outdated Show resolved Hide resolved
@alexjfisher alexjfisher force-pushed the code_climate2 branch 2 times, most recently from 028ad1d to 7729aa1 Compare February 14, 2023 17:25
ekohl
ekohl reviewed Feb 14, 2023
View reviewed changes
lib/puppet-lint.rb Outdated Show resolved Hide resolved
@alexjfisher alexjfisher force-pushed the code_climate2 branch 2 times, most recently from a3b33ea to 37e27d0 Compare February 14, 2023 21:49
ekohl
ekohl approved these changes Feb 15, 2023
View reviewed changes
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A future improvement would be to factor out stdout to its own class (something like a8df415, but then tested and cleaned up).

@chelnak chelnak self-requested a review February 28, 2023 14:09
@chelnak chelnak merged commit 5accc62 into puppetlabs:main Feb 28, 2023
4 of 5 checks passed
@chelnak chelnak added the enhancement New feature or request label Feb 28, 2023
@alexjfisher
Copy link
Author

Related PDK change in puppetlabs/pdk-templates#499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
community enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexjfisher @ekohl @chelnak @ia-content