(SERVER-43) fix http report processor - now with tests! #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the ArgumentError triggered by the http report processor.
KevinCorcoran
changed the title
Refactor test for extensibility and add a test case for HTTP POST. Use a ScriptingContainer with persistent local variables, so we can re-use the HttpClient instance for additional tests.
'encode64' incorrectly adds a '\n' to the end of the encoded string - use 'strict_encode64' which isn't stupid. Also remove the errant ':' character in the 'Authorization' header used by the ruby HTTP client.
| (is (= "hi" (.runScriptlet scripting-container "response.body")))) | ||
|
|
||
| (testing "invvalid credentials" |
|
@nwolfe - comments addressed. |
| (is (= "hi" (.runScriptlet scripting-container "c.get('/', {}).body")))) | ||
|
|
||
| (testing "HTTP POST" |
There was a problem hiding this comment.
Extra test coverage, yay!
|
👍 |
1 similar comment
|
👍 |
nwolfe
added a commit
that referenced
this pull request
Oct 10, 2014
…processor (SERVER-43) fix http report processor - now with tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.