From 04cb560b3d5c043726c4c1abd0b6d193f3f0117d Mon Sep 17 00:00:00 2001 From: Glenn Sarti Date: Sat, 30 May 2020 19:33:05 +0800 Subject: [PATCH] (maint) Do not use git for Gemspec files Previously the gemspec was using 'git ls-file' to retrieve the file list for the gem, however this is problematic during development as untracked files are not added, which can then cause an incomplete gem tarball to used during the acceptance tests, which cause false negative test results. This commit updates the Gemspec to use the more common Dir[..] method as used in the PDK. --- puppet-strings.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/puppet-strings.gemspec b/puppet-strings.gemspec index 6e7236f1e..64f548faf 100644 --- a/puppet-strings.gemspec +++ b/puppet-strings.gemspec @@ -20,7 +20,7 @@ Gem::Specification.new do |s| 'LICENSE', 'README.md', ] - s.files = `git ls-files`.split("\n") - Dir['.*', '*.gemspec'] + s.files = Dir['CHANGELOG.md', 'README.md', 'LICENSE', 'lib/**/*', 'exe/**/*'] s.add_runtime_dependency 'yard', '~> 0.9.5' s.add_runtime_dependency 'rgen'