Merge pull request #542 from jeffmccune/ticket/2.7rc/12881_fix_cron_m…

…issing_provider_error_message

(#12881) Fix cron type default name error on windows

lib/puppet/type/cron.rb

@@ -352,7 +352,10 @@ def should_to_s(newvalue = @should)
 
       The user defaults to whomever Puppet is running as."
 
-    defaultto { Etc.getpwuid(Process.uid).name || "root" }
+    defaultto {
+      struct = Etc.getpwuid(Process.uid)
+      struct.respond_to?(:name) && struct.name or 'root'
+    }
   end
 
   newproperty(:target) do

spec/unit/type/cron_spec.rb

@@ -468,4 +468,10 @@
     entry = described_class.new(:name => "test_entry", :ensure => :absent)
     entry.value(:command).should == nil
   end
+
+  it "should default to user => root if Etc.getpwuid(Process.uid) returns nil (#12357)" do
+    Etc.expects(:getpwuid).returns(nil)
+    entry = described_class.new(:name => "test_entry", :ensure => :present)
+    entry.value(:user).should eql "root"
+  end
 end