Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: master
Commits on Jul 6, 2015
  1. @peterhuene

    Merge pull request #4043 from peculater/puppet-agent-cli-should-error…

    peterhuene authored
    …-instead-of-daemonize
    
    (PUP-4776) Make 'puppet agent arg' error instead of silently running the catalog
  2. @peterhuene

    Merge pull request #3977 from yastupin/pup4633

    peterhuene authored
    (PUP-4633) fix non-ASCII user comment with ruby >= 2.1
  3. @peculater

    (PUP-4776) Make 'puppet agent arg' error instead of silently running …

    peculater authored
    …the catalog
    
    Currently, 'puppet agent' only analyses options beginning with '--', such as '--test' and
    '--disable'.  Any other words after agent are ignored.  That is different from the way that
    commands like 'puppet resource' and 'puppet apply' work, mainly because those require
    an argument, while 'puppet agent' does not.  This has led to, for instance, one of our new
    sysadmins typing 'puppet agent disable' instead of 'puppet agent --disable' and being
    terribly surprised when about 5 minutes later the server died.
    
    This patch raises an error if someone on the CLI tries to invoke 'puppet agent' with what
    has to be an invalid argument.
  4. @hlindberg

    Merge pull request #4067 from thallgren/issue/4489/add-data-provider-…

    hlindberg authored
    …to-metadata
    
    (PUP-4489) Add data_provider to module metadata
  5. @thallgren

    (PUP-4489) Add data_provider to module metadata

    thallgren authored
    Adds a 'data_provider' entry to metadata.json. The entry must
    be an object with a 'name' and an optional 'attributes' array.
Commits on Jul 1, 2015
  1. @hlindberg

    Merge pull request #4007 from thallgren/issue/pup-4702/immutable-type…

    hlindberg authored
    …-system
    
    (PUP-4702) Replace RGEN based Type system with immutable classes
  2. @thallgren

    (PUP-4702) Add enumeration support to more types

    thallgren authored
    This commit moves the enumerable? method to the PAnyType and
    implements Enumerable on PEnumType, PTupleType, PStructType and
    PVariantType.
  3. @thallgren

    (PUP-4702) Use map/reduce instead of collect/inject

    thallgren authored
    Also fixes some minor issues with common types, removes a dangling
    comment and adds a comment about an optimization. All requested
    in review.
  4. @thallgren

    (PUP-4702) Replace RGEN based Type system with immutable classes

    thallgren authored
    This commit changes all RGEN based classes in the Puppet Type
    system into plain Ruby classes. Each class is immutable which means
    that the instance is completely initialized by its initializer and
    that only attr_readers exists to read the properties of the instance.
    
    Each class has a `DEFAULT` constant defined which is the singleton
    default for the type that the class represents. Some types have
    additional constants such as `PCollectionType::DEFAULT_SIZE` or
    `PStringType::NON_EMPTY`.
    
    In addition to creating immutable classes, some performance critical
    methods were also moved out of the polymorphic dispatch. This includes
    methods like `assignable?`, `instance?` and `generalize`. The methods
    are still available on the TypeCalculator to ensure backward
    compatibility.
Commits on Jun 30, 2015
  1. @joshcooper

    Merge remote-tracking branch 'upstream/pr/4040'

    joshcooper authored
    * upstream/pr/4040:
      (PUP-2509) Add -H flag to svcs to strip column headers
  2. @joshcooper

    Merge remote-tracking branch 'upstream/pr/3910'

    joshcooper authored
    * upstream/pr/3910:
      (PUP-4653) switch FileBucket::Dipper to custom URLs
  3. @drewfisher314

    (PUP-2509) Add -H flag to svcs to strip column headers

    drewfisher314 authored
    Without this flag, self.instances returns an entry for a service named
    'FMRI':
    
    $ puppet resource service
    
    service { 'FMRI':
      ensure => 'stopped',
        enable => 'false',
    }
    
    <...>
    
    This is from the header:
    
    $ svcs | head -5
    STATE          STIME    FMRI     <-----
    legacy_run     Jun_22   lrc:/etc/rc2_d/S47pppd
    legacy_run     Jun_22   lrc:/etc/rc2_d/S89PRESERVE
    disabled       Jun_22   svc:/platform/i86pc/acpihpd:default
    online         Jun_22   svc:/system/early-manifest-import:default
Commits on Jun 29, 2015
  1. @joshcooper

    Merge remote-tracking branch 'upstream/stable'

    joshcooper authored
    * upstream/stable:
      (PUP-4758) Update Rspec `raise_error` calls for Rspec 3.3
  2. @joshcooper

    (maint) Shorten vcr fixture filename length

    joshcooper authored
    Previously CI was failing on windows exceeding the maximum windows path
    length of 260 characters. This occurs because our jenkins instance uses
    a prefix that includes the job name and each axis in the matrix:
    
        C:\jenkins\workspace\platform_aio-puppet_unit-ruby_master-windows\RUBY\ruby-2.1.5.2-x86\SLAVE\unit-win2012\
    
    This commit shortens the spec path from 159 characters to 125. When
    combined with the 107 character prefix, will be 232 characters, less
    than the max.
  3. @joshcooper

    Merge remote-tracking branch 'upstream/pr/4050' into stable

    joshcooper authored
    * upstream/pr/4050:
      (PUP-4758) Update Rspec `raise_error` calls for Rspec 3.3
  4. @peterhuene

    Merge pull request #3934 from dalen/pup2573-agent_lock

    peterhuene authored
    (PUP-2573) Make agent locker raise LockError if we fail to aquire lock
  5. @MikaelSmith

    Merge pull request #3741 from ffrank/maint/cleaner-http-stubbing

    MikaelSmith authored
    (maint) Introduce VCR to the bundle, have nicer HTTP stubbing
Commits on Jun 26, 2015
  1. @whopper

    (PUP-4758) Update Rspec `raise_error` calls for Rspec 3.3

    whopper authored
    In Rspec 3.3, any calls to `raise_error` without arguments
    are met with loud warnings during test runs. This commit updates
    every such call to include the expected exception type and
    expected exception output in most cases.
  2. @joshcooper

    Merge remote-tracking branch 'upstream/stable'

    joshcooper authored
    * upstream/stable:
      (PUP-4787) Add additional checks for node[name] serialization
      (PUP-4787) Initialize @vars of Puppet:Node with expected defaults
  3. @joshcooper

    Merge remote-tracking branch 'upstream/pr/4057' into stable

    joshcooper authored
    * upstream/pr/4057:
      (PUP-4787) Add additional checks for node[name] serialization
      (PUP-4787) Initialize @vars of Puppet:Node with expected defaults
  4. @hlindberg

    (PUP-4787) Add additional checks for node[name] serialization

    hlindberg authored
    Before this there was a possibility that code could initialize a
    Puppet::Node with a nil name because the method intialize_from_hash is
    public. The check for name being nil was in a class method
    (self.from_data_hash).
    
    This makes the implementation more robust as it moves the check for nil
    name down to where it affects the @name.
    
    Spec tests updated to also check for nil name.
  5. @thallgren

    Merge branch 'stable'

    thallgren authored
  6. @thallgren

    Merge branch '3.x' into stable

    thallgren authored
    Conflicts:
    	spec/unit/functions/hiera_spec.rb
  7. @thallgren

    Merge pull request #4058 from hlindberg/PUP-4789_hiera-functions-usin…

    thallgren authored
    …g-wrong-scope
    
    (PUP-4789) Make hiera_include function call include in calling scope
Commits on Jun 25, 2015
  1. @hlindberg

    (PUP-4789) Make hiera_include function call include in calling scope

    hlindberg authored
    Before this, the hiera_include function would call the include function
    with its closure scope instead of the calling scope. This caused the
    include function to not understand in which class the include was made,
    and variable scoping would be wrong - not seeing variables in node
    scope.
    
    The hiera 4.x functions already received the calling scope, but did not
    pass it on to the post processing method, that in hiera_include's case
    performs the call to the include function.
  2. @MikaelSmith

    Merge pull request #4053 from whopper/PUP-4770/revert_zone_debug_change

    MikaelSmith authored
    (PUP-4770) Revert "(maint) Fix debug and error output"
  3. @hlindberg

    (PUP-4787) Initialize @vars of Puppet:Node with expected defaults

    hlindberg authored
    Before this, (introduced in PUP-4775 where the serialization
    was changed to use Psych support for asymetric serialization), two of
    Puppet::Node's instance varaibles (@classes, and @parameters) where
    initialized to nil on deserialization. When again serializing a check
    was made if these where empty? (which fails).
    
    This was caught by a roundtripping acceptance test where a
    yaml-serialized node was turned into json via serialization.
    
    The fix was to initialize to [] and {} respectively in the
    initialize_from_hash method.
    
    This also adds a unit test for a roundtrip serialization where classes
    and parameters are not included in the serialized data.
  4. @thallgren

    Merge branch 'stable'

    thallgren authored
  5. @thallgren

    Merge pull request #4056 from hlindberg/PUP-4775_node-serialization-fix

    thallgren authored
    (PUP-4775) Make Puppet::Node serialize env as a string in YAML
  6. @whopper

    (PUP-4770) Revert "(maint) Fix debug and error output"

    whopper authored
    This reverts commit 1764674.
    Originally, this commit changed the Solaris Zone provider's debug
    and error messages to use the global utilities, which means that
    they aren't prefixed with the provider context. This was done to
    circumvent PUP-3088, which is now fixed.
  7. @joshcooper

    Merge remote-tracking branch 'upstream/stable'

    joshcooper authored
    * upstream/stable:
      (maint) Fix failing test caused by databinding being in effect
      (PUP-4537) Skip rdoc tests on windows
      (PUP-4777) Allow hiera 3 as a puppet dependency
      (PUP-4749) testdir incorrectly used in calling all functions test
      (PUP-3539) add specs globbing ACL in fileserver.conf
  8. @joshcooper

    Merge remote-tracking branch 'upstream/pr/4054' into stable

    joshcooper authored
    * upstream/pr/4054:
      (maint) Fix failing test caused by databinding being in effect
  9. @hlindberg

    (maint) Fix failing test caused by databinding being in effect

    hlindberg authored
    The evaluator spec tests started failing when Hiera 3.0.1 was brought
    in. This was unexpected as the tests does not rely on data binding being
    in effect. Instead it is running with string variables to ensure that no
    unknown variables are used in the tests. At the same time, tests had not
    made the now required variables $environment and $trusted available.
    
    The fix is to run these tests without databinding.
Commits on Jun 24, 2015
  1. @MikaelSmith

    Merge pull request #4045 from joshcooper/ticket/stable/PUP-4777-bump-…

    MikaelSmith authored
    …hiera-dependency
    
    (PUP-4777) Allow hiera 3 as a puppet dependency
  2. @MikaelSmith

    Merge pull request #4044 from er0ck/acceptance/master/PUP-4712-fix_en…

    MikaelSmith authored
    …vironment_scenario_acceptance_test_nuances
    
    (PUP-4712) fix environment scenario acceptance test nuances
Something went wrong with that request. Please try again.