(PUP-10955) Normalize environment name to symbol before caching #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins please test this with servertests |
luchihoratiu
force-pushed
the
PUP-10955-un-revert
branch
from
7624faf
to
3a1f46b
Compare
|
jenkins please test this with servertests |
luchihoratiu
force-pushed
the
PUP-10955-un-revert
branch
from
3a1f46b
to
091af08
Compare
|
jenkins please test this with servertests |
joshcooper
reviewed
Jul 20, 2021
|
PR #8673 is been merged, so you should be able to rebase onto upstream/6.x |
luchihoratiu
force-pushed
the
PUP-10955-un-revert
branch
2 times, most recently
from
5a5f5a3
to
505e785
Compare
|
Acceptance tests passed (here) so this should be good to further review/merge ✅ |
joshcooper
reviewed
Jul 21, 2021
joshcooper
approved these changes
Jul 21, 2021
The `Puppet::Environments::Cached.get` method says it accepts Strings or Symbols. This commit normalizes the environment name before caching and getting the environment to avoid duplicated environments in cache (as String and as Symbol).
luchihoratiu
force-pushed
the
PUP-10955-un-revert
branch
from
505e785
to
a6e0a6b
Compare
gimmyxd
approved these changes
Jul 22, 2021
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Jul 24, 2021
* upstream/6.x: (packaging) Updating manpage file for 6.x Revert "Merge pull request puppetlabs#8673 from joshcooper/guard_text_domain" Revert "Merge pull request puppetlabs#8708 from joshcooper/missing_guard_methods" Revert "Merge pull request puppetlabs#8702 from luchihoratiu/PUP-10955-un-revert" (docs)(DOC-5035) Remove "master" in generated docs Conflicts: lib/puppet/defaults.rb lib/puppet/environments.rb lib/puppet/type/filebucket.rb man/man5/puppet.conf.5 Accepted text_domain_service revert in 6.x Accepted `Puppet Server` changes in 6.x
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Jul 27, 2021
…PUP-10955-un-revert"" This reverts commit c709fa4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Puppet::Environments::Cached.getmethod says it accepts Strings or Symbols. This commit normalizes the environment name before caching and getting the environment to avoid duplicated environments in cache (as String and as Symbol).