Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Relax gem dependencies on Facter and Hiera #1372

Merged
merged 1 commit into from over 1 year ago

2 participants

Jeff McCune Matthaus Owens
Jeff McCune
Owner

Without this patch applied an older version of Hiera is automatically
installed as a dependency installing Puppet. This is a problem because
there are important bug fixes happening in later minor versions of
Hiera. The same is true of Facter. The cause of the problem is a tight
specification of gem :hiera, "~> 1.0.0" which means "greater than
1.0.0 but less then 1.1.0". 1.1.2 is the current latest bug fix version
of Hiera.

This patch fixes the problem by relaxing the dependency to "~> 1.0"
which means "greater than 1.0.0 and less than 2.0.0"

Matthaus Owens haus commented on the diff
ext/project_data.yaml
... ...
@@ -15,8 +15,8 @@ gem_executables: 'puppet'
15 15
 gem_default_executables: 'puppet'
16 16
 gem_forge_project: 'puppet'
17 17
 gem_runtime_dependencies:
18  
-  facter: '~> 1.6.11'
19  
-  hiera: '~> 1.0.0'
  18
+  facter: '~> 1.6'
3
Matthaus Owens Owner
haus added a note

The facter dependency can't be less than 1.6.2 because the osfamily fact was introduced in that release and puppet 3.x depends in several places on the osfamily fact.

There also were some ruby 1.9 fixes later in the 1.6 series that allow facter 1.6 and puppet 3.x to play well together on ruby 1.9.

Jeff McCune Owner
Matthaus Owens Owner
haus added a note

~> 1.6 is probably the best we can get for right now. When 1.7 ships it will make for a much cleaner dependency, since there won't be features in any 1.7.x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jeff McCune Relax gem dependencies on Facter and Hiera
Without this patch applied an older version of Hiera is
automatically installed as a dependency installing Puppet.  This is a
problem because there are important bug fixes happening in later minor
versions of Hiera.  The same is true of Facter.  The cause of the
problem is a tight specification of `gem :hiera, "~> 1.0.0"` which means
"greater than 1.0.0 but less then 1.1.0".  1.1.2 is the current latest
bug fix version of Hiera.

This patch fixes the problem by relaxing the dependency to "~> 1.0"
which means "greater than 1.0.0 and less than 2.0.0"
8e38dd9
Jeff McCune jeffmccune merged commit bc19ea9 into from
Jeff McCune jeffmccune closed this
Jeff McCune jeffmccune deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 06, 2013
Jeff McCune Relax gem dependencies on Facter and Hiera
Without this patch applied an older version of Hiera is
automatically installed as a dependency installing Puppet.  This is a
problem because there are important bug fixes happening in later minor
versions of Hiera.  The same is true of Facter.  The cause of the
problem is a tight specification of `gem :hiera, "~> 1.0.0"` which means
"greater than 1.0.0 but less then 1.1.0".  1.1.2 is the current latest
bug fix version of Hiera.

This patch fixes the problem by relaxing the dependency to "~> 1.0"
which means "greater than 1.0.0 and less than 2.0.0"
8e38dd9
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. 4  ext/project_data.yaml
4  ext/project_data.yaml
@@ -15,8 +15,8 @@ gem_executables: 'puppet'
15 15
 gem_default_executables: 'puppet'
16 16
 gem_forge_project: 'puppet'
17 17
 gem_runtime_dependencies:
18  
-  facter: '~> 1.6.11'
19  
-  hiera: '~> 1.0.0'
  18
+  facter: '~> 1.6'
  19
+  hiera: '~> 1.0'
20 20
 gem_rdoc_options:
21 21
   - --title
22 22
   - "Puppet - Configuration Management"
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.