(AIX) Fix some failing AIX specs #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These specs use the default service provider, but in the case where that provider doesn't support the enable property, they were failing when testing various values for that property. Many of these went unnoticed because they weren't actually making any assertions, but rather checking that nothing failed, so now they do assert.
These tests were creating a resource and a launchd provider instance from that resource, when the resource already has a (default) provider instance. In most cases this was working fine, because the resource's provider instance wasn't often being referred to. However, a couple of tests were trying to set the enable property of the resource, which fails on systems without an enableable provider. Now, we explicitly set the resource's provider to launchd, as use its provider instance for all of our tests.
This test was setting path to /bin with the assumption that it didn't contain cd, and therefore the only cd would be a shell built-in. On system which *do* contain /bin/cd, this was failing. Now we just use a bogus path so this will work everywhere.
This test was assuming, incorrectly, that it will always be run from inside a git repo with git installed. Now we properly handle the case where it's not, and skip the test.
|
Reviewing now... |
|
code looks fine.. checking out to try on AIX. |
|
tests pass locally, rsyncing to AIX to verify |
|
Confirmed that these fix issues on AIX. 👍 |
jeffweiss
pushed a commit
that referenced
this pull request
Jan 23, 2013
(AIX) Fix some failing AIX specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #1406, but against the aix branch, plus one more commit which wasn't necessary in master.
Fixes two issues with non-enableable service providers, a spec that fails outside of a git directory or without git available, and an exec test that assumed /bin/cd doesn't exist.