(maint) Enable logging for all `puppet doc` commands #1580

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@adrienthebo
Contributor

adrienthebo commented Apr 3, 2013

Without this commit the --debug and --verbose flags can only be used
with the rdoc mode and doesn't interact with the other documentation
types. This commit extracts the logging configuration to apply to all
documentation modes.

In addition this defaults the log level to :warning. Since warning and
above messages will be emitted on stderr this will not affect the normal
operation of the puppet doc command. Using --debug or --verbose will
emit messages on stdout, so they should not be used while
programmatically generating docs.

@djmitche

This comment has been minimized.

Show comment Hide comment
@djmitche

djmitche Apr 3, 2013

Contributor

👍

Contributor

djmitche commented Apr 3, 2013

👍

@puppetcla

This comment has been minimized.

Show comment Hide comment
@puppetcla

puppetcla Apr 3, 2013

CLA Signed by adrienthebo on 2011-03-07 21:00:00 -0800

CLA Signed by adrienthebo on 2011-03-07 21:00:00 -0800

@adrienthebo

This comment has been minimized.

Show comment Hide comment
@adrienthebo

adrienthebo Apr 3, 2013

Contributor

There are definitely some broken specs in here, but I'm having some trouble reproducing on my development machine. I'm investigating.

Contributor

adrienthebo commented Apr 3, 2013

There are definitely some broken specs in here, but I'm having some trouble reproducing on my development machine. I'm investigating.

(maint) Enable logging for all `puppet doc` commands
Without this commit the --debug and --verbose flags can only be used
with the rdoc mode and doesn't interact with the other documentation
types. This commit extracts the logging configuration to apply to all
documentation modes.

In addition this defaults the log level to :warning. Since warning and
above messages will be emitted on stderr this will not affect the normal
operation of the `puppet doc` command. Using --debug or --verbose will
emit messages on stdout, so they should not be used while
programmatically generating docs.
@jeffmccune

This comment has been minimized.

Show comment Hide comment
@jeffmccune

jeffmccune Apr 10, 2013

Contributor

summary: Merged into master as be09a83. This should be released in Puppet 3.2. Thanks again for the contribution!

-Jeff

Contributor

jeffmccune commented Apr 10, 2013

summary: Merged into master as be09a83. This should be released in Puppet 3.2. Thanks again for the contribution!

-Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment