Add pkgin package provider

[mudge]

pkgin is a binary package manager for pkgsrc as used by Joyent on their SmartMachines. This is a package provider for pkgin with the standard installable and uninstallable features.

My Puppet Labs Redmine account can be found at http://projects.puppetlabs.com/users/3814

[jhelwig]

Not a major thing, but unless self.parse needs to exist for the type/provider system here, it might be better to have a method name with a bit more semantic meaning. Something along the lines of parse_pkgin_line?

[jhelwig]

matching_package isn't really needed here. #detect will return the first element where the block returns true, so this could be written as:

packages.detect do |package|
  properties = self.class.parse(package)
  properties && resource[:name] == properties[:name]
end

Where this is the last thing in def query.

[mudge]

The problem here is that what needs to be returned is properties, not the original package so detect alone won't be enough. If we separate out the detection from the parsing, it'll mean parsing twice instead of once, e.g.

matching_package = packages.detect do |package|
  properties = self.class.parse(package)
  properties && resource[:name] == properties[:name]
end

self.class.parse(matching_package) if matching_package

[jhelwig]

These three are really unnecessary given that the later tests will fail if any of these methods are missing. We're usually removing tests like this as we encounter them since they don't really provide any extra coverage.

[jhelwig]

Paul,

Thanks for working on this provider. Sorry for taking so long to get around to reviewing it. I had a few comments, but nothing major. Let me know if you won't have time to address them. It's all stuff that can easily be addressed when merging in the pull request, if you're busy.

[mudge]

Hey Jacob,

Thanks for the review; I've renamed parse to parse_pkgin_line and removed the redundant tests as per your remarks. Re the detect, please see my in-line comments but perhaps there is a better way to tackle this.

[jhelwig]

I completely glossed over the return of properties, instead of package. Your comment makes complete sense, and I don't see an obviously better way to do it, off hand.

I've squashed the two commits down into one, and merged it into the master branch in 9b7c73a.