Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Extend Pacman provider for Archlinux to use Yaourt #241

Merged
merged 2 commits into from Feb 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

GregSutcliffe commented Dec 2, 2011

Extend Pacman provider for Archlinux to use the popular AUR helper
Yaourt if it is available. Continues to use Pacman for any command
where it makes sense to do so, and only calls out to Yaourt when
an package isn't found in the standard repositories.

Contributor

slippycheeze commented Jan 31, 2012

Hey there. Sorry you didn't get a response for so long.

I don't see a ticket associated with this. Was there one where discussion of the change went on, or is this it?

If we can answer a couple of question about why this is better, and all, I am happy to get this change merged in.

Contributor

GregSutcliffe commented Jan 31, 2012

Hi Daniel,

Yes, I opened feature request #11145 regarding this, which has more details about my thinking. Obviously, happy to have a chat about it, as it might not be the best way to achieve my aims :)

More generally, I know there are other outstanding issues with ArchLinux, and since I've taken over the Puppet and Facter AUR packages for Arch, they're next on my list (I'm looking at the work Thomas Hatch did on the services stuff, mainly). So, I'm keen to get more dialog about ArchLinux going.

Are you heading down to FOSDEM this weekend. I'll be there, so if you want to chat about this stuff in person, lets hook up.

Greg

Contributor

slippycheeze commented Jan 31, 2012

@GregSutcliffe - thanks. I am happy with the change, and it seems like using the wrapper script is reasonable when the user has it installed. It just strictly adds features to pacman, and doesn't take anything away, so the user won't be surprised if they install it but don't generally use it, right?

The one outstanding issue is that the tests don't pass with this change, and the new behaviour isn't checked. Is there any chance you can have a go at those? If not, we can totally do it, but it will push this back behind checking on other pull requests and all.

Feel free to ping me here, hit me up in IRC, or on the ticket for support getting that done, but http://projects.puppetlabs.com/projects/puppet/wiki/Development_Writing_Tests has some good help getting started with them all.

Contributor

slippycheeze commented Jan 31, 2012

...oh, and apparently the pull request needs a rebase to get in. :)

Contributor

GregSutcliffe commented Feb 1, 2012

I'm definitely a fan of the "least surprise" principle - so no, users shouldn't see an issue. The contention is more from the fact that Yaourt is only one possible AUR wrapper for Archlinux. A better solution would be to implement a provider for the AUR directly, but I've not had time to do that yet. I hope to get to that, but this is a stopgap in the meantime.

I'll try and get a rebase done soon - might not be til next week though, if that's ok?

Contributor

slippycheeze commented Feb 1, 2012

@GregSutcliffe - no problem at all. Thanks for being willing to do that, I appreciate it. Given you are willing to step up to the plate I am happy to give you a fairly big voice in what the "right" behaviour here is for an Arch user. :)

@slippycheeze slippycheeze added a commit that referenced this pull request Feb 20, 2012

@slippycheeze slippycheeze Merge pull request #241 from GregSutcliffe/pacman_aur_support
Extend Pacman provider for Archlinux to use Yaourt
b8a6f23

@slippycheeze slippycheeze merged commit b8a6f23 into puppetlabs:master Feb 20, 2012

Contributor

slippycheeze commented Feb 20, 2012

@GregSutcliffe - thanks for your patience; a brief cold delayed my getting back to merging this change. I do appreciate your taking the time to rebase it.

Contributor

GregSutcliffe commented Feb 20, 2012

Apologies for not getting those tests written - I spent some time staring at RSpec after our IRC chat, but it just wasn't clicking, and I've not had time to get back to it yet. I'll try and make sure there are some test on my next pull request.

Thanks for the merge :)

@hlindberg hlindberg pushed a commit to hlindberg/puppet that referenced this pull request Oct 16, 2014

Nick Fagerlund Merge pull request #241 from zacharyalexstern/master
Addeed known issue for reappearing nodes
c5a8040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment