New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-1840) Add an sha256 checksum type to Puppet::Util::Checksums #2451

Merged
merged 1 commit into from Mar 26, 2014

Conversation

Projects
None yet
5 participants
@jaredjennings
Copy link
Contributor

jaredjennings commented Mar 19, 2014

This patch makes SHA-256 available for use as a checksum algorithm by other parts of Puppet, alongside MD5 and SHA-1. (See commit message for further details.) The known_checksum_types method is used by code added in the configurable digest algorithm pull request, which will be filed after this one.

(PUP-1840) Add an sha256 checksum type to Puppet::Util::Checksums
Without this patch applied, Puppet doesn't know how to perform
checksums of files using the SHA-256 algorithm. This precludes Puppet
from being useful on hosts configured for compliance with U.S. Federal
Information Processing Standard (FIPS) 140-2.

The SHA-2 family of algorithms is recommended for use by the
U.S. National Institute of Standards and Technology (NIST) in FIPS
140-2; SHA-256 is the algorithm from this family having the shortest
output.

This patch makes SHA-256 available for use as a checksum algorithm by
other parts of Puppet, alongside MD5 and SHA-1.
@puppetcla

This comment has been minimized.

Copy link

puppetcla commented Mar 19, 2014

CLA signed by all contributors.

@peterhuene

This comment has been minimized.

Copy link
Contributor

peterhuene commented Mar 19, 2014

Travis CI failure a result of a 1.8.7 syntax error that sneaked into master. It can likely be safely ignored.

@ferventcoder ferventcoder merged commit fcfb1f2 into puppetlabs:master Mar 26, 2014

1 check was pending

default The Travis CI build is in progress
Details
@ferventcoder

This comment has been minimized.

Copy link
Contributor

ferventcoder commented Mar 26, 2014

This piece was merged into master at d1f0a45 and should be included as part of 3.6.x

@jaredjennings jaredjennings deleted the jaredjennings:fix/master/add-sha256-20140319 branch Mar 27, 2014

@adrienthebo

This comment has been minimized.

Copy link

adrienthebo commented on fcfb1f2 Apr 3, 2014

Is this commit the same as puppetlabs#2451 ? If so this pull request might need to be rebased on master and this commit should be removed so there isn't duplication.

This comment has been minimized.

Copy link
Owner

jaredjennings replied Apr 3, 2014

Yes, it is the same. I made all three pull requests at the same time, based on what was the master HEAD at the time, which did not include this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment