Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
(PUP-2711) Make manifest-directory load recursively when future parser is on #2834
This makes recursive loading of manifests available when the future parser is on. All .pp files in the manifestdir and its subdirectories will be loaded in alphabetical depth first order (a directory's entries are processed alphabetically, if it is a directory, it is processed before the remaining files in the current directory).
I think that the glob should either use the PathPattern instance or should go through the Puppet::Filesystem layer in order to get more of our file handling going through that layer.
This changes the loaded of a manifest reference that is a directory to include all .pp recursively in this directory. The content is sorted so that all content of directory b comes before file c in its parent directory (rule applied recursively).
This makes the ability to load all .pp files under a manifest dir recursively conditional to parser == future. (It will become the standard in Puppet 4.0). This is done to avoid slurping in lots of files in case users kept other files around in a subdirectory in the belief that they would not be loaded. Thus making it harder to upgrade. This also adds a test that runs for future parser.