Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-3750) Support :include: in mailalias type #3447

Merged

Conversation

dspinellis
Copy link
Contributor

The mailalias type does not allow the specification of included files,
which contain an alias's elements. Such alias entries are commonly
specified in the an MTA's aliases file through the following syntax.

aliasname: :include: /path/to/file

Specifying the rest of an ":include:" line as a recipient does not
work, because the existing mailalias type will quote the entry.

This change adds a new parameter named "file" to the mailalias type,
which allows the indirect specification of a file containing the
recipients. The parameter parses and generates ":include:" alias entries.

Also, as recommended by @joshcooper, remove legacy unneeded "should" from
recipient property implementation. This fixes a gratuitous difference
between the new file property implementation and the recipient property
one.

The mailalias type does not allow the specification of included files,
which contain an alias's elements. Such alias entries are commonly
specified in the an MTA's aliases file through the following syntax.

aliasname: :include: /path/to/file

Specifying the rest of an ":include:" line as a recipient does not
work, because the existing mailalias type will quote the entry.

This change adds a new parameter named "file" to the mailalias type,
which allows the indirect specification of a file containing the
recipients.  The parameter parses and generates ":include:" alias entries.

Also, as recommended by @joshcooper, remove legacy unneeded "should" from
recipient property implementation.  This fixes a gratuitous difference
between the new file property implementation and the recipient property
one.
MikaelSmith pushed a commit that referenced this pull request Jan 5, 2015
@MikaelSmith MikaelSmith merged commit 1fd3d2b into puppetlabs:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants