(PUP-3750) Support :include: in mailalias type #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mailalias type does not allow the specification of included files, which contain an alias's elements. Such alias entries are commonly specified in the an MTA's aliases file through the following syntax. aliasname: :include: /path/to/file Specifying the rest of an ":include:" line as a recipient does not work, because the existing mailalias type will quote the entry. This change adds a new parameter named "file" to the mailalias type, which allows the indirect specification of a file containing the recipients. The parameter parses and generates ":include:" alias entries. Also, as recommended by @joshcooper, remove legacy unneeded "should" from recipient property implementation. This fixes a gratuitous difference between the new file property implementation and the recipient property one.
MikaelSmith
pushed a commit
that referenced
this pull request
Jan 5, 2015
(PUP-3750) Support :include: in mailalias type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mailalias type does not allow the specification of included files,
which contain an alias's elements. Such alias entries are commonly
specified in the an MTA's aliases file through the following syntax.
aliasname: :include: /path/to/file
Specifying the rest of an ":include:" line as a recipient does not
work, because the existing mailalias type will quote the entry.
This change adds a new parameter named "file" to the mailalias type,
which allows the indirect specification of a file containing the
recipients. The parameter parses and generates ":include:" alias entries.
Also, as recommended by @joshcooper, remove legacy unneeded "should" from
recipient property implementation. This fixes a gratuitous difference
between the new file property implementation and the recipient property
one.