(PUP-3974) test source attribute, all checksums

[er0ck]

Prior to this change the source_attributes test did not cover the puppet
apply cases for all checksums. This change adds these tests.
This change also removes the sleep(1) in favor of a loop which checks to
ensure we're ready to move on, saving up to a second.

[joshcooper]

it was surprising to me that checksum included the trailing comma, which led to unintuitive log messages:

Using a local file path (checksum => ctime,)

Can we move the comma to the manifest where the checksum is used, or just remove entirely (since no properties/parameters come after checksum in the manifests below)?

[joshcooper]

This test passed for rhel7 and win2012r2-rubyx64, but it takes ~ 10 mins on Windows because it runs puppet apply twice for each checksum type, where each run takes ~ 16 seconds.

be rake ci:test:aio CONFIG=config/nodes/win2012r2-rubyx64.yaml  SHA=215e36f962dfd7080947d78a1a1340b0aadcfa62 TESTS=tests/resource/file/source_attribute.rb
...
seo2bu30c2m5h80.delivery.puppetlabs.net (agent-2012r2-x86_64-rubyx64) 00:55:22$ cmd.exe /c puppet apply --modulepath=C:/cygwin64/tmp/local_source_file_test.XP46nu -e "file { 'C:/cygwin64/tmp/local_source_file_test.XP46nu/targetmtime': source => 'puppet:///modules/source_mod/source', ensure => present, checksum => mtime, }"
...
seo2bu30c2m5h80.delivery.puppetlabs.net (agent-2012r2-x86_64-rubyx64) executed in 16.06 seconds
...
       Total Suite Time: 613.05 seconds
      Average Test Time: 613.05 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1

Can we rework this test to create a single manifest with a number of file resources, run puppet apply once to create the initial files, then run puppet apply again and verify no changes are necessary?

We have the same issue with the symbolic file mode test and I'd prefer not to add another 10mins to the test suite time.

[er0ck]

good comments @joshcooper
windows runtime down to ~100 seconds \o/
added the lite tests beyond 512 bytes as well. nice