(PUP-4926) Make it possible to form relationship with 3x resource #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this it was not possible to form a relationship with a 3x Resource instance. This problem occurs if passing a PResourceType to a defined type or class. The evaluation transforms the PResourceType to a Puppet::Pops::Parser::Resource which is given as argument value. When later, the defined resource (or class) is evaluated, a relationship could not be formed using this variable. The problem was that the Relationship Operator implementation did not transform the Parser::Resource back to a PResourceType - instead it failed with an error that Resource was not a CatalogEntry.
Before this, the wrong issue was raised for a 'not-catalog-type' in a relationship operator. This led to an error message with less useful information.
thallgren
added a commit
that referenced
this pull request
Jul 28, 2015
…-resource (PUP-4926) Make it possible to form relationship with 3x resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, passing a resource reference as an attribute value resulted in that value not being useful as an operand in a resource expression.
This also corrects a faulty choice of issue leading to an error message with less information.