Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-5712) Fix so that TypeParser can handle negative numbers #4574

Conversation

@thallgren
Copy link
Member

thallgren commented Jan 15, 2016

Prior to this commit, the TypeParser would not recognize an
UnaryMinusExpression and hence raise an error when one was encountered.
This commit ensures that an unary minus is handled correctly so that
types like Integer[default, -1] can be used in a function dispatch.

Prior to this commit, the TypeParser would not recognize an
UnaryMinusExpression and hence raise an error when one was encountered.
This commit ensures that an unary minus is handled correctly so that
types like `Integer[default, -1]` can be used in a function dispatch.
@hlindberg hlindberg added the Language label Jan 15, 2016
@hlindberg

This comment has been minimized.

Copy link
Contributor

hlindberg commented Jan 15, 2016

+1 on merging but waiting on green light to merge to stable (waiting for release work to take place).

hlindberg added a commit that referenced this pull request Jan 27, 2016
…-typeparser

(PUP-5712) Fix so that TypeParser can handle negative numbers
@hlindberg hlindberg merged commit c1ab5a8 into puppetlabs:stable Jan 27, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thallgren thallgren deleted the thallgren:issue/pup-5712/unary-minus-in-typeparser branch Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.