(PUP-5929) Add mapping between runtime classes and puppet types #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to declare a mapping between a runtime type pattern and a puppet type pattern to the PL parser and validator. A mapping can be declares as: ``` type Runtime(ruby, [<pattern>, <repl>]) = [<pattern>, <repl>] ``` where <pattern> are regexps and <repl> are strings that references groups in the regexps using \<n> syntax.
| @@ -103,7 +101,7 @@ def self.provide_from_name_path(name, name_path) | |||
| end | |||
|
|
|||
| def self.find_class(name_path) | |||
| name_path.reduce(Object) do |ns, name| | |||
| name_path.inject(Object) do |ns, name| | |||
There was a problem hiding this comment.
Always prefer reduce over inject (we use map/reduce as the paradigm instead of collect/inject).
|
CLA signed by all contributors. |
Makes the ClassLoader use the predefined constant `TypeFormatter::NAME_SEGMENT_SEPARATOR` and use `Array#shift` to pop first element of array instead of creating a copy using a range.
thallgren
force-pushed
the
issue/pup-5929/type-alias-runtime-mapping
branch
from
7ec7fa2
to
96fdf07
Compare
This commit adds the ImplementationRegistry that is the keeper of all registered type mappings. The registry is string based so that types and implementations can be mapped without being required to exists at the time of mapping.
This commit changes the `TypeCalculator#infer` method so that it makes an attempt to find a mapped Puppet type before it concludes that an instance is a Runtime type.
thallgren
force-pushed
the
issue/pup-5929/type-alias-runtime-mapping
branch
from
96fdf07
to
09b921d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create mappings between runtime types (here, only ruby since the runtime is ruby) and types in the Puppet Type system. Mappings are declared using an alias like expression where the left hand side is a Runtime type (either a single type or array with regex + replacement) and the right hand side is either a Puppet type or an array with regex + replacement.
A mapping is registered in string form in the new class
ImplementationRegistry. A loader (the effective loader at the place where the mapping occurs) is also part of the mapping. This means that the singleton registry will be able to produce a Type from a Runtime (or vice versa) from any place in the code. This is necessary since no loader is present in the majority of cases. TheTypeCalculatorin particular, have no access to a loader instance and it must be able to produce types from a mapping when type inference is performed.