Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use systemd by default on Ubuntu 16.10 #5009
Conversation
kylog
commented
Jun 7, 2016
|
Thanks @nacc! One minor nit: can you update the commit message on the refactor commit to prepend "(maint)" to the summary line, e.g. so it looks like: |
nacc
added some commits
Jun 6, 2016
|
@kylog Just updated the commit message. Will update the Jira issue as well! Thanks for the quick feedback! |
kylog
merged commit 509feea
into
puppetlabs:master
Jun 7, 2016
puppetcla
commented
Jun 7, 2016
|
CLA signed by all contributors. |
|
@kylog apologies for asking in a closed issue, but from a maintenance perspective, would it make sense to adjust the checks so that systemd is assumed to be the default on >= 15.04? e.g. in lib/puppet/provider/service/systemd.rb: defaultfor :operatingsystem => :ubuntu, (:operatingsystemmajrelease <=> "15.04") == 1 Otherwise, we're going to have to make similar changes for each new release of Ubuntu (and it will be broken when we do). I'm not sure how to modify/update the other functionality, though, in spec/unit/provider/service/systemd_spec.rb, correspondingly: [ '15.04', '15.10', '16.04', '16.10' ].each do |ver| (I don't know Ruby very well, I apologize) |
|
@kylog alternatively, could we flip the default so that Ubuntu is assumed to have systemd and just put the (now finite) set of releases that did have upstart as the default in a list? |
nacc commentedJun 7, 2016
No description provided.