Document missing --noop option for puppet apply #570

Merged
merged 1 commit into from Mar 14, 2012

Conversation

Projects
None yet
2 participants
@francois
Contributor

francois commented Mar 9, 2012

I had to resort to the Interwebs to find that this option exists. puppet help apply didn't tell me.

jeffmccune added a commit that referenced this pull request Mar 14, 2012

Merge pull request #570 from francois/master
Document missing --noop option for puppet apply

@jeffmccune jeffmccune merged commit 719e137 into puppetlabs:master Mar 14, 2012

@jeffmccune

This comment has been minimized.

Show comment
Hide comment
@jeffmccune

jeffmccune Mar 14, 2012

Contributor

@francois I went ahead and merged this, but I'm certain that man page is automatically generated by ronn. This patch may get overwritten if the man page is auto generated again.

Could you look and see if there's a rake task and if so, how it generates the man page automatically?

Contributor

jeffmccune commented Mar 14, 2012

@francois I went ahead and merged this, but I'm certain that man page is automatically generated by ronn. This patch may get overwritten if the man page is auto generated again.

Could you look and see if there's a rake task and if so, how it generates the man page automatically?

@francois

This comment has been minimized.

Show comment
Hide comment
@francois

francois Mar 14, 2012

Contributor

Thanks for merging. I see the man pages are generated, but I don't see how the noop option makes it to the man page. I tried this:

diff --git a/lib/puppet/application/apply.rb b/lib/puppet/application/apply.rb
index 739452d..d12f913 100644
--- a/lib/puppet/application/apply.rb
+++ b/lib/puppet/application/apply.rb
@@ -12,6 +12,7 @@ class Puppet::Application::Apply < Puppet::Application
   option("--verbose","-v")
   option("--use-nodes")
   option("--detailed-exitcodes")
+  option("--noop")

   option("--apply catalog",  "-a catalog") do |arg|
     Puppet.deprecation_warning <<EOM

To no avail. If someone can point me in the right direction, I'll happily document that option.

Contributor

francois commented Mar 14, 2012

Thanks for merging. I see the man pages are generated, but I don't see how the noop option makes it to the man page. I tried this:

diff --git a/lib/puppet/application/apply.rb b/lib/puppet/application/apply.rb
index 739452d..d12f913 100644
--- a/lib/puppet/application/apply.rb
+++ b/lib/puppet/application/apply.rb
@@ -12,6 +12,7 @@ class Puppet::Application::Apply < Puppet::Application
   option("--verbose","-v")
   option("--use-nodes")
   option("--detailed-exitcodes")
+  option("--noop")

   option("--apply catalog",  "-a catalog") do |arg|
     Puppet.deprecation_warning <<EOM

To no avail. If someone can point me in the right direction, I'll happily document that option.

melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018

Merge pull request #570 from MikaelSmith/PCP-729
(PCP-729) Change default ping-interval to 2 minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment