Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
(PUP-9092) Improve process handling on Windows (corrupted by author, see #7038) #7033
Waiting for CLA signature by @onyxmaster
@onyxmaster - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html
Hi @onyxmaster, thank you for your contribution! The change makes sense. I think the only downside is the ruby thread can't be interrupted for up to 15 seconds once it calls into the native method (assuming the child process is long lived). But maybe newer ruby versions handle that correctly now?
About which version to target, the 4.10.x is in security mode only and 5.3.x is in deep maintenance mode. Please target the 5.5.x base branch.
referenced this pull request
Sep 2, 2018
Well, seems that Github believes that force pushing wasn't a good idea, there are now no new commits between my master and origin 5.5.x, so I cant change the PR base, and it closed the PR automatically, see the new PR. Sorry for any inconvenience, I'm "not really good" with git.