Skip to content

Gemfile, created while trying to set up this to run on Windows#89

Closed
haf wants to merge 1 commit into
puppetlabs:masterfrom
haf:master
Closed

Gemfile, created while trying to set up this to run on Windows#89
haf wants to merge 1 commit into
puppetlabs:masterfrom
haf:master

Conversation

@haf

@haf haf commented Sep 1, 2011

Copy link
Copy Markdown
Contributor

started hacking at getting a Gemfile up so that I can try this out in Windows without having to remember all dependencies. btw, tests are failing and I can't install win32-service through bundler, because it won't compile in the git bash

… Windows without having to remember all dependencies. btw, tests are failing and I can't install win32-service through bundler, because it won't compile in the git bash
@jhelwig

jhelwig commented Sep 1, 2011

Copy link
Copy Markdown
Contributor

There are a number of tests that are known to fail on Windows due to things like missing support in types/providers. If you run the tests by doing something like rspec --tag ~fails_on_windows spec, then you'll only be running the tests that should actually have all the support necessary to run. Eventually the fails_on_windows tag will go away, but for now, it's marking the areas where we know Puppet does not work correctly on Windows, but should before we can call the initial Windows support "done".

@mmrobins

mmrobins commented Sep 1, 2011

Copy link
Copy Markdown
Contributor

I think this is a great idea, although I'll have to run the code a bit more as I've had problems in the past once bundler starts getting inserted into rake files.

One thing is I don't think facter should be listed in the dev gem dependencies since it's possible, and rather common when developing to NOT have facter installed as a gem. Instead it might be running from source (by putting facter's lib in RUBYLIB) or from a package. Facter has loadpath issues if it's installed with different versions more than one way on a system.

Also, I think this is ticket 7143. I'll update that ticket to point to this pull request. http://projects.puppetlabs.com/issues/7143

@mmrobins

mmrobins commented Sep 1, 2011

Copy link
Copy Markdown
Contributor

So this has happened to me before and it doesn't seem like it should, but when I check out that patch and run simple rake tasks, they're failing with the new bundler file even though the gem it's failing on is in a group in the Gemfile so shouldn't be required. Maybe it's something with my setup, but it seems simple enough it shouldn't be.

Also, with this patch I don't see the point of doing the require 'bundler' in the default rake task, since all it does is rake -T to print out rake tasks and shouldn't depend on gems being installed. It makes sense for the rake unit and rake spec tasks though.

Here's the output I get:

─[~/work/puppet]─[matthewrobinson@mattmac]─[20110901 - 10:16]-
╰─ [0]% rake
rake/gempackagetask is deprecated. Use rubygems/package_task instead
rake aborted!
Could not find gem 'win32-dir (>= 0, runtime)' in any of the gem sources listed in your Gemfile.

Tasks: TOP => default
(See full trace by running task with --trace)
╭─[~/work/puppet]─[matthewrobinson@mattmac]─[20110901 - 10:16]-
╰─ [1]% rake unit
rake/gempackagetask is deprecated. Use rubygems/package_task instead
rake aborted!
Could not find gem 'win32-dir (>= 0, runtime)' in any of the gem sources listed in your Gemfile.

Tasks: TOP => unit
(See full trace by running task with --trace)

@haf

haf commented Sep 1, 2011

Copy link
Copy Markdown
Contributor Author

facter is required, or some unit tests will fail with something like 'cannot require 'facter''. I drove the gemfile from the errors I got from a fairly clean system.

I think running rake should not fail directly; but it shouldn't not fail either - requiring, e.g. with require 'bundler/setup', at the top doesn't show any tasks at all, unless bundle install has run. So it's a problem either way - I most often put a Bundler.setup at the top of my rakefiles - so perhaps this is a better way of doing it.

I think 'win32-dir' comes from win32-service, but I'm not sure. Strange, I'm not getting that error message though.

When trying to get the aforementioned service gem to install, by changing

PLATFORM
    x86-mwin32

to

PLATFORM
    x86-mswin

, it seems my ruby install got fried. Don't try the above. ^^

@haf haf closed this Nov 25, 2011
Iristyle pushed a commit to Iristyle/puppet that referenced this pull request Sep 9, 2014
…les_init_script

(PE-2776) Wait for puppet to start in sles init script
hlindberg pushed a commit to hlindberg/puppet that referenced this pull request Oct 16, 2014
puppet node_aws terminate example
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
…xp-config

(maint) Update PXP readme example config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants