Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Support multiple Postgres instances #110

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Oct 14, 2020

In a PE DR setup there are two active Postgres instances. Currently multiple Postgres instances are not handled well in terms of data collection nor graphing. This change ensures that the data is properly tagged with the Postgres server name as well as updating the graphs for multi-server support based on the server tag.

@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard::profile::master::postgres is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jarretlavallee
Copy link
Contributor

@seanmil Thank you for submitting these PRs! It looks like the spec tests are broken. We will fix those and ask you to rebase these once fixed.

@seanmil
Copy link
Contributor Author

seanmil commented Oct 14, 2020

@seanmil Thank you for submitting these PRs! It looks like the spec tests are broken. We will fix those and ask you to rebase these once fixed.

Thanks. I saw the failures and took a very quick look at what was causing them, but we are nearly all EL and so I don't have much familiarity with the apt module.

@jarretlavallee
Copy link
Contributor

The issue is in being tracked in #115. I should have a PR up in the morning to fix it.

@jarretlavallee
Copy link
Contributor

@seanmil Would you mind updating the branches now that #116 has been merged?

Tag the data with the name of the Postgres server instead of the
server performing the data collection.
Include the server name in all aliases so the data points can
be identified back to their server. Add a '$server' variable
allowing selection of the systems to show based on the tag
values.
@seanmil
Copy link
Contributor Author

seanmil commented Oct 15, 2020

@seanmil Would you mind updating the branches now that #116 has been merged?

@jarretlavallee done! thanks!

@suckatrash suckatrash merged commit cbc10d6 into puppetlabs:master Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants