Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

change to http when client cert is false #131

Merged
merged 1 commit into from
May 26, 2021

Conversation

WBasson
Copy link

@WBasson WBasson commented Feb 9, 2021

proposed fix for #130

@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard::profile::puppetdb is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Willem Basson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can merge this when the CLA is signed.

@jarretlavallee
Copy link
Contributor

@WBasson Do you have a minute to review and sign the CLA? https://cla-assistant.io/puppetlabs/puppet_metrics_dashboard?pullRequest=131

@gavindidrichsen gavindidrichsen changed the base branch from master to main May 7, 2021 08:26
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner May 7, 2021 08:26
@jarretlavallee jarretlavallee merged commit 357bd69 into puppetlabs:main May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants