Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Remove slash from dashboard name #132

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

timidri
Copy link
Contributor

@timidri timidri commented Feb 11, 2021

Using a slash in a title of a grafana_dashboard resource
leads to errors when Puppet tries to manage the dashboard.

@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard::dashboards::puppet_metrics is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@timidri timidri requested a review from Sharpie February 11, 2021 14:31
Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Sharpie Sharpie merged commit 2625b19 into puppetlabs:master Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants