This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Enable remote PuppetDB collection in 2019.8.5+ #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suckatrash
suggested changes
Apr 1, 2021
|
Good call. I just pushed up a commit with it in there. |
jarretlavallee
force-pushed
the
client_auth
branch
from
b04f853
to
f877e88
Compare
suckatrash
approved these changes
Apr 1, 2021
|
I was not expecting that failure. I can fix it by adding |
jarretlavallee
force-pushed
the
client_auth
branch
2 times, most recently
from
30affb9
to
eec9d7b
Compare
|
Alright, that last commit should fix some of the last issues. Hopefully, the acceptance tests are green now. |
suckatrash
approved these changes
Apr 1, 2021
added 6 commits
May 27, 2021 12:47
Prior to this commit, there was a fact that was not scoped. This commit adds a puppetdb version fact and consolidates the dashboard overwrite fact into the puppet_metrics_dashboard hash.
Prior to this commit, PuppetDB collection was restricted to localhost on recent PuppetDB versions by default. It was possible to specify the PuppetDB nodes manually, but the default parameters would not populate based on specific PuppetDB versions. This commit updates the logic to automatically collect data from PuppetDB versions that allow remote collection.
Prior to this commit there was a function that did not align with its function. puppetdb_no_remote_metrics was used to determine if the v1 or v2 endpoints and dashboards were used. This commit renames the function to better align with its current purpose.
Prior to this commit, there was a spec test failure due to an empty array that should be populated by the trusted certname fact. This commit adds that fact.
Prior to this commit, the puppetdb v2 logic was more complex than needed. This update changes to anything over 5.5.19 to use v2, which should fix the issues with some newer versions using v1 metrics.
Prior to this commit, the centos spec tests were not matching into with the os name fact and being skipped. This commit fixes those spec tests by adding Centos to the when case.
jarretlavallee
force-pushed
the
client_auth
branch
from
9efcf34
to
0c232d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables remote PuppetDB collection by default when using PE 2019.8.5+. It does this by adding a new PuppetDB version fact and using that in a PuppetDB query for the PuppetDB nodes. The PR includes some clean up such as the following.
puppet_metrics_dashboardhash