Added repo_gpgcheck and single quotes to influxdb

[ghost]

Added to yumrepo influxdb:

• repo_gpgcheck
• single quotes
• spacing adjustment

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

puppet_metrics_dashboard::repos is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[hammondr]

Since the repodata in the influxdb yum repo isn't signed, repo_gpgcheck yumrepo parameter is needed for "hardened" systems where /etc/yum.conf specifies the default repo_gpgcheck=1.

[jarretlavallee]

Thanks for the PR @di2ejenkins!

As the repo_gpgcheck = 0 does not work for all users, we will need to add a parameter to determine its value. Please add a parameter to configure this setting.

[hammondr]

I think the existing code base only works when repo_gpgcheck = 0 at the global yum level (either explicitly or because that is the default). This change allows the influx repo to work when repo_gpgcheck = 1 at the global yum level.

As the repo_gpgcheck = 0 does not work for all users, we will need to add a parameter to determine its value. Please add a parameter to configure this setting.

I have no problem with the new parameter but the logic isn't quite right IMO. Do you also want to parameterize existingrepo_gpgcheck and gpgcheck params elsewhere in the file?

[jarretlavallee]

That's a good point

Not valid

[hammondr]

@jarretlavallee, is there anything else you wanted Tara or me to do here?

[jarretlavallee]

LGTM

[jarretlavallee]

Thanks for the PR @hammondr. This has been merged and will be included in the next release.