-
Notifications
You must be signed in to change notification settings - Fork 40
(SUP-2732) Fix PDB data tagged onto dashboard server issue and templa… #191
Conversation
puppet_metrics_dashboard::profile::puppetdb is a typethat may have no external impact to Forge modules. This module is declared in 0 of 578 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Please add the selector for the puppetdb_host and test. If that works, I am good to merge.
$server_name = $puppetdb_host ? {
'localhost' => $clientcert,
default => $puppetdb_host
}
|
Tested working, please review. Thanks |
manifests/profile/puppetdb.pp
Outdated
| @@ -64,6 +64,11 @@ | |||
| $metrics_version = 'v1/mbeans' | |||
| } | |||
|
|
|||
| $server_name = $puppetdb_host ? { | |||
| "localhost" => $clientcert, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double quoted string without any variables to interpolate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
I rebased it, merging 👍 |
…tes errors
This will fix the telegraf data taggings for the data collected from PDB endpoints.
Also, there are some issues on PDB dashboard templates that have been fixed as well to correctly display the data.