Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

(SUP-2732) Fix PDB data tagged onto dashboard server issue and templa… #191

Merged
merged 1 commit into from
Oct 26, 2021
Merged

(SUP-2732) Fix PDB data tagged onto dashboard server issue and templa… #191

merged 1 commit into from
Oct 26, 2021

Conversation

henrywangpuppet
Copy link
Contributor

…tes errors

This will fix the telegraf data taggings for the data collected from PDB endpoints.

Also, there are some issues on PDB dashboard templates that have been fixed as well to correctly display the data.

@henrywangpuppet henrywangpuppet requested a review from a team as a code owner October 18, 2021 05:56
@puppet-community-rangefinder
Copy link

puppet_metrics_dashboard::profile::puppetdb is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Please add the selector for the puppetdb_host and test. If that works, I am good to merge.

$server_name = $puppetdb_host ? {
  'localhost' => $clientcert,
  default => $puppetdb_host
}

@henrywangpuppet
Copy link
Contributor Author

Tested working, please review. Thanks

@@ -64,6 +64,11 @@
$metrics_version = 'v1/mbeans'
}

$server_name = $puppetdb_host ? {
"localhost" => $clientcert,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double quoted string without any variables to interpolate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m0dular
Copy link
Contributor

m0dular commented Oct 26, 2021

I rebased it, merging 👍

@m0dular m0dular merged commit c946f1e into puppetlabs:main Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants