This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Accept 503 responses from PE /status APIs #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The puppetlabs/trapperkeeper-status library that provides the
/status/v1API of various PE services will respond with aHTTP 503 status code if any sub-service is not in a healthy state.
By default, Telegraf HTTP inputs will only accept 200 as a
successful response code. This state of affairs leads to situations
like an outage in
pe-orchestration-servicesresulting in Telegrafrejecting perfectly good JRuby metrics from
pe-puppetserveroncompilers because the
pcp-brokersub-service is unhealthy.This commit updates the Telegraf configuration to accept HTTP 503
as a successful return code in addition to 200 so that an attempt
is made to process and store metrics data during outages of external
services.