This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Allow ssl_dir to be configured via Hiera #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppet_metrics_dashboard::certs is a typethat may have no external impact to Forge modules. This module is declared in 0 of 578 indexed public
|
Sharpie
commented
Nov 6, 2021
This commit updates the `puppet_metrics_dashboard::certs` defined type by promoting the `ssl_dir` variable to be a parameter. The default value remains `$settings::ssldir`, but can be overridden by Hiera. This change provides users the option to work around two situations where `$settings::ssldir` does not point to the right location: - `$settings::ssldir` returns the SSL directory of the _Puppet Server_ or other process compiling the catalog. This is usually-but-not-always the same directory that the Puppet Agent applying the catalog stores its keypair in. - Bolt's `bolt apply` command runs a `puppet apply` process on remote targets with many major Puppet settings, such as `ssldir`, shifted into a tempdir sandbox to avoid the possibility of side-effects that could affect Puppet daemons. Fixes puppetlabs#183
m0dular
force-pushed
the
parameterize-ssldir
branch
from
48a6401
to
4f07732
Compare
m0dular
approved these changes
Dec 15, 2021
|
Rebased since this was a bit stale, I'll let the tests run for posterity. |
|
One GCP error for Alma, I think we're good to merge 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
puppet_metrics_dashboard::certsdefined typeby promoting the
ssl_dirvariable to be a parameter. The defaultvalue remains
$settings::ssldir, but can be overridden by Hiera.This change provides users the option to work around two situations
where
$settings::ssldirdoes not point to the right location:$settings::ssldirreturns the SSL directory of the Puppet Serveror other process compiling the catalog. This is usually-but-not-always
the same directory that the Puppet Agent applying the catalog stores
its keypair in.
Bolt's
bolt applycommand runs apuppet applyprocess on remotetargets with many major Puppet settings, such as
ssldir, shiftedinto a tempdir sandbox to avoid the possibility of side-effects
that could affect Puppet daemons.
Fixes #183