This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Ensure http timeout is set in all inputs.http* for telegraf #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the http_response_timeout did not apply to the puppetserver status API call in telegraf, so setting it had no effect on the timeout. This commit adds the timeout to all `inputs.http` and `inputs.httpjson` items in the `telegraf.conf.epp`.
|
LGTM - merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the http_response_timeout did not apply to the
puppetserver status API call in telegraf, so setting it had no effect on
the timeout. This commit adds the timeout to all
inputs.httpandinputs.httpjsonitems in thetelegraf.conf.epp.Prior to this PR, we were seeing timeouts on the puppetserver status endpoint and there was no way to set it in the configuration file.