This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Use certname consistently for key files #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this module did not work for environments where certname != FQDN. With this change, certname is consistently used instead of FQDN when naming certificate/key files.
genebean
reviewed
May 17, 2019
There was a problem hiding this comment.
I have vague memories of @suckatrash saying there was a reason for fqdn here but, if not, I think this is a good change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this module did not work for environments where certname != FQDN. With this change, certname is consistently used instead of FQDN when naming certificate/key files.