This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Select PuppetDB metrics based on version #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of the PuppetDB metrics queried for, global.generate-retry-message-time and global.retry-persistence-time, stopped being available with PuppetDB 4.3.0. This patch uses the PE version detection logic to correctly select the metric set to pull.
|
@seanmil - I've been meaning to clean this up for forever! Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the PuppetDB metrics queried for, global.generate-retry-message-time
and global.retry-persistence-time, stopped being available with
PuppetDB 4.3.0. This patch uses the PE version detection logic to
correctly select the metric set to pull.