This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix archive dashboard query for compile time #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the "Archive Puppetserver Performance" dashboard
template with two fixes for the catalog compile time metric:
- The `mean()` function is replaced with `distinct()` so that null
values are properly handled.
- The `catalog-metrics` measurement is an array of different
timings of operations that make up compilation. The query
is updated to select only `compile` and `static_compile`
operations.
|
Kicking the travis job as it looks transient. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the "Archive Puppetserver Performance" dashboard
template with two fixes for the catalog compile time metric:
The
mean()function is replaced withdistinct()so that nullvalues are properly handled.
The
catalog-metricsmeasurement is an array of differenttimings of operations that make up compilation. The query
is updated to select only
compileandstatic_compileoperations.