This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Use the puppetserver.jruby metrics in the dashboard examples
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genebean
approved these changes
Jan 2, 2020
|
Rebasing off master should get tests working again |
Prior to this commit, we used the pe-jruby metrics in the example dashboards. Since these were released into the open source puppet versions in 5.3.x, we can now use the `jruby` to ensure compatiblity with OSP and puppetlabs-puppet_metrics_collector/pull/29. This change updates the dashboards to use `puppetserver.jruby` instead of `puppetserver.pe-jruby`.
|
Thanks @genebean and @suckatrash. I just rebased so hopefully the tests pass now. |
|
It looks like #85 included most of the changes in this PR. Only dashboard is left to change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we used the pe-jruby metrics in the example
dashboards. Since these were released into the open source puppet
versions in 5.3.x, we can now use the
jrubyto ensure compatiblity withOSP and puppetlabs-puppet_metrics_collector/pull/29. This change updates
the dashboards to use
puppetserver.jrubyinstead ofpuppetserver.pe-jruby.