This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
OSP Compatibility Updates #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2020 11:54
Prior to this commit, telegraf was using insecure SSL connections to PuppetDB. This worked in some cases, but would fail in other cases due to not providing a client certificate. As the clent certificate is available on the host, this commit enables using the client certificate by default on all PuppetDB queries.
Prior to this commit, the profiles would not fail with OSP, but added some additional metrics that are not used in OSP. This commit makes some minor updates to the conditionals and removes the file sync query from OSP PuppetDB.
genebean
suggested changes
Jan 27, 2020
This commit aligns the style with best practices and the repos style lines.
suckatrash
approved these changes
Jan 31, 2020
|
@jarretlavallee - could you also update changelog with this PR? |
This commit adds the changes from #87 to the changelog.
|
Thanks @suckatrash. The changelog has been updated. It put it as a Y release with the change to the client ssl certs. Let me know if you think it would qualify as a Z release instead. |
|
Makes sense to me. @genebean anything else needed here from your perspective? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some basic OSP compatibility updates to the module. It includes the following.
Update thepe_server_versionconditionals to check ifNotUndefpe_server_versionis not definedpostgres_accessclass if it is OSP since it uses PE classes and we cannot guarantee the method used in OSP.The biggest change is the client certificates on the PuppetDB API requests over skipping validation.
This is a draft PR since there are no spec tests on these profiles and want to identify what is appropriate.