Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Make the tidy resource optional #93

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Make the tidy resource optional #93

merged 1 commit into from
Apr 10, 2020

Conversation

suckatrash
Copy link
Contributor

@suckatrash suckatrash commented Apr 8, 2020 •
edited
Loading

Wraps the tidy resource in a conditional and doesn't add it by default.

genebean
genebean reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but I feel the parameter name in misleading... how about changing to tidy_telegraph or tidy_telegraf_configs?

@suckatrash suckatrash requested a review from genebean April 8, 2020 16:00
@suckatrash
Copy link
Contributor Author

@genebean good call, went with tidy_telegraf_configs

@suckatrash suckatrash merged commit 7fd4a36 into master Apr 10, 2020
@suckatrash suckatrash deleted the optionally_tidy branch April 10, 2020 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@genebean genebean genebean approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suckatrash @genebean @MartyEwings