Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv telegraf agent os-specific params to hiera data #101

Merged
merged 1 commit into from Oct 24, 2022

Conversation

zoojar
Copy link
Contributor

@zoojar zoojar commented Oct 20, 2022

No description provided.

@zoojar zoojar requested a review from a team as a code owner October 20, 2022 14:23
@puppet-community-rangefinder
Copy link

puppet_operational_dashboards::telegraf::agent is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, functionally it looks correct, let me confer with my team if this is a direction we want to go in

@zoojar
Copy link
Contributor Author

zoojar commented Oct 20, 2022 via email

@MartyEwings MartyEwings added the enhancement New feature or request label Oct 21, 2022
Copy link
Collaborator

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m0dular m0dular merged commit 7363f6f into puppetlabs:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants