Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDB-1034) Ezbake source based testing #1179

Closed

Conversation

@kbarber
Copy link
Contributor

commented Dec 11, 2014

This change switched PuppetDB over to use the ezbake_utils helpers in ezbake
to install PuppetDB via source. This effectively means the old installation
methodology can be retired.

The beaker-tests-source.sh script is now modified to ensure that leiningen
is now installed (since its required by ezbake helpers in beaker).

Some minor code was removed that is no longer needed, but a major retirement
patch will be forthcoming to remove the greater amount of code no longer
required. Since it was deemed such a patch would make this patch hard to read.

Signed-off-by: Ken Barber ken@bob.sh

@kbarber kbarber changed the title (PDB-1034) Ezbake source based testing WIP: (PDB-1034) Ezbake source based testing Dec 11, 2014
@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2014

This requires the following patches to be merged in (and maybe released for beaker, or at least pinned in this patch):

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2014

This is going to fail on RHEL7 (due to https://tickets.puppetlabs.com/browse/QENG-1594), and there is a single transient failure on the maven download, that can be solved in the future with a mirror most probably.

@pljenkinsro

This comment has been minimized.

Copy link

commented Dec 11, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/287/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2014

The EL7 issue is related to a broken sshd_config. More information updated in the ticket:

https://tickets.puppetlabs.com/browse/QENG-1594

@kbarber kbarber changed the title WIP: (PDB-1034) Ezbake source based testing (PDB-1034) Ezbake source based testing Jan 5, 2015
@puppetcla

This comment has been minimized.

Copy link

commented Jan 6, 2015

CLA signed by all contributors.

@kbarber kbarber force-pushed the kbarber:pdb-1034-ezbake-pr-testing branch from 0f3b92b to 0a69346 Jan 9, 2015
@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 9, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/392/

This change switched PuppetDB over to use the ezbake_utils helpers in ezbake
to install PuppetDB via source. This effectively means the old installation
methodology can be retired.

The beaker-tests-source.sh script is now modified to ensure that leiningen
is now installed (since its required by ezbake helpers in beaker).

Some minor code was removed that is no longer needed, but a major retirement
patch will be forthcoming to remove the greater amount of code no longer
required. Since it was deemed such a patch would make this patch hard to read.

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber kbarber force-pushed the kbarber:pdb-1034-ezbake-pr-testing branch from 0a69346 to 27a4cb2 Jan 12, 2015
@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/398/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

@pljenkinsro retest this please

@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/399/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

@pljenkinsro retest this please

@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/400/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

@pljenkinsro retest this please

@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/401/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

@pljenkinsro retest this please

@pljenkinsro

This comment has been minimized.

Copy link

commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/404/

fi
mkdir leiningen

wget https://raw.githubusercontent.com/technomancy/leiningen/stable/bin/lein -O leiningen/lein

This comment has been minimized.

Copy link
@waynr

waynr Jan 13, 2015

Contributor

It is definitely best to pin to a specific version of leiningen; with this line leiningen stable can change at any time regardless of whether it's been tested against puppetdb and therefore may introduce bugs that would break puppetdb's CI pipeline asynchronous to any changes in this repo or our CI system. QE has actually configured jenkins slaves to install a specific version of leiningen to address this kind of problem. I believe the current version of leiningen availabe on jenkins slaves is 2.4.3.

In my opinion, this kind of script should not be in project-specific repos exactly because of snippets like this--as a QE automation engineer I can't reasonably be expected to audit all projects for quirks like this which may blow up at any time. I realize that addressing this issue is well outside the scope of the current PR or any currently ticketed work. Just want to begin socializing some of what I perceive to be the negative impact of storing CI scripts outside of CI.

This comment has been minimized.

Copy link
@kbarber

kbarber Jan 13, 2015

Author Contributor

Fair points, the reason why we had this script in the first place was the differences between stable & master and leiningen requirements now - I guess I overlooked the fact the slaves already have a working leiningen today. But I can adjust this, shouldn't be a problem.

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2015

Closing this PR for now, as I plan on making changes and don't want to create testing noise here. I'll re-open it later when its ready.

@kbarber kbarber closed this Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.