Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Bump to latest pristmatic/schema #1351

Merged
merged 1 commit into from Apr 15, 2015

Conversation

Projects
None yet
3 participants
@kbarber
Copy link
Contributor

commented Apr 14, 2015

This aligns us with trapperkeeper bumping to latest schema, so we won't have
conflicts later on.

Signed-off-by: Ken Barber ken@bob.sh

(maint) Bump to latest pristmatic/schema
This aligns us with trapperkeeper bumping to latest schema, so we won't have
conflicts later on.

Signed-off-by: Ken Barber <ken@bob.sh>
@pljenkinsro

This comment has been minimized.

Copy link

commented Apr 14, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1036/

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

For some reason travis is stating there is a permission issue installing sqlite3 gem. No idea where this came from, but I've seen it twice now (unrelated to this patch).

@kbarber

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

Okay, this was a transient issue with travis as I suspected. All green now.

@@ -69,7 +69,8 @@
[puppetlabs/kitchensink ~ks-version]
[puppetlabs/trapperkeeper ~tk-version]
[puppetlabs/trapperkeeper-webserver-jetty9 ~tk-jetty9-version]
[prismatic/schema "0.2.2"]
[prismatic/schema "0.4.0"]
[prismatic/plumbing "0.4.2"]

This comment has been minimized.

Copy link
@senior

senior Apr 15, 2015

Contributor

Does TK and schema 0.4.0 now depend on different versions of plumbing? Is that why we need to declare a direct dependency on plumbing?

This comment has been minimized.

Copy link
@kbarber

kbarber Apr 15, 2015

Author Contributor

TK right now (as in the version we use) depends on plumbing 0.2.1, which is not compatible with schema 0.4.0. So if we don't include plumbing this fails. We could I think ... wait for a TK release, bump to that and probably avoid this extra requirement if so desired.

This comment has been minimized.

Copy link
@senior

senior Apr 15, 2015

Contributor

No, I think it's ok to merge, makes sense why we're adding it.

@senior

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2015

+1 will merge when the current pipeline clears

senior added a commit that referenced this pull request Apr 15, 2015

Merge pull request #1351 from kbarber/maint/stable/bump-schema-version
(maint) Bump to latest pristmatic/schema

@senior senior merged commit c7e2ac6 into puppetlabs:stable Apr 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.