(#14586) Incorrect start-stop-daemon args in Debian init script#166
Merged
Conversation
When we try to stop the daemon, we were passing in `--name puppetdb` instead of `--exec $JAVA_BIN`. Since our process isn't actually named puppetdb, that initial call wouldn't actually terminate the process. It would then fall-through to a second code path where the init script would then try to kill *all* processes with $JAVA_BIN as the executable. That's, like, not so great and stuff. I've corrected the args to start-stop-daemon to use both the pidfile and the executable name to give us a precise match. With that in place, the secondary code path is no longer necessary. A pleasant side-effect of this fix is that now stopping PuppetDB is extremely fast, instead of taking 30 seconds or so. Signed-off-by: Deepak Giridharagopal <deepak@puppetlabs.com>
nicklewis
added a commit
that referenced
this pull request
May 24, 2012
(#14586) Incorrect start-stop-daemon args in Debian init script
wkalt
pushed a commit
to wkalt/puppetdb
that referenced
this pull request
Sep 23, 2014
…eation-500 (maint) Fix 500 when trying to create group w/RBAC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we try to stop the daemon, we were passing in
--name puppetdbinstead of--exec $JAVA_BIN. Since our process isn't actually named puppetdb, thatinitial call wouldn't actually terminate the process. It would then
fall-through to a second code path where the init script would then try to kill
all processes with $JAVA_BIN as the executable. That's, like, not so great
and stuff.
I've corrected the args to start-stop-daemon to use both the pidfile and the
executable name to give us a precise match. With that in place, the secondary
code path is no longer necessary.
A pleasant side-effect of this fix is that now stopping PuppetDB is extremely
fast, instead of taking 30 seconds or so.
Signed-off-by: Deepak Giridharagopal deepak@puppetlabs.com